netdev - Re: [PATCH net-next 3/7] dpaa2-eth: Distribute ingress frames based on VLAN prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200515.104146.1397850162301312137.davem@davemloft.net>
Date:   Fri, 15 May 2020 10:41:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org, ruxandra.radulescu@....com
Subject: Re: [PATCH net-next 3/7] dpaa2-eth: Distribute ingress frames
 based on VLAN prio

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Fri, 15 May 2020 19:52:56 +0300

> +/* Configure ingress classification based on VLAN PCP */
> +static int set_vlan_qos(struct dpaa2_eth_priv *priv)
> +{
> +	struct device *dev = priv->net_dev->dev.parent;
> +	struct dpkg_profile_cfg kg_cfg = {0};
> +	struct dpni_qos_tbl_cfg qos_cfg = {0};
> +	struct dpni_rule_cfg key_params;
> +	void *dma_mem, *key, *mask;

Please declare mask as "u16 *"

> +	*(u16 *)mask = cpu_to_be16(VLAN_PRIO_MASK);

And remove this cast, no other code changes are necessary.  Not even
to the calculation of the pointer value.