netdev - Re: [PATCH net-next v2 0/3] mptcp: fix MP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200515.123059.151278519835306555.davem@davemloft.net>
Date:   Fri, 15 May 2020 12:30:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, cpaasch@...le.com,
        mptcp@...ts.01.org, mathew.j.martineau@...ux.intel.com
Subject: Re: [PATCH net-next v2 0/3] mptcp: fix MP_JOIN failure handling

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 15 May 2020 19:22:14 +0200

> Currently if we hit an MP_JOIN failure on the third ack, the child socket is
> closed with reset, but the request socket is not deleted, causing weird
> behaviors.
> 
> The main problem is that MPTCP's MP_JOIN code needs to plug it's own
> 'valid 3rd ack' checks and the current TCP callbacks do not allow that.
> 
> This series tries to address the above shortcoming introducing a new MPTCP
> specific bit in a 'struct tcp_request_sock' hole, and leveraging that to allow
> tcp_check_req releasing the request socket when needed.
> 
> The above allows cleaning-up a bit current MPTCP hooking in tcp_check_req().
> 
> An alternative solution, possibly cleaner but more invasive, would be
> changing the 'bool *own_req' syn_recv_sock() argument into 'int *req_status'
> and let MPTCP set it to 'REQ_DROP'.
> 
> v1 -> v2:
>  - be more conservative about drop_req initialization
> 
> RFC -> v1:
>  - move the drop_req bit inside tcp_request_sock (Eric)

Series applied, thanks Paolo.