lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 14 May 2020 18:38:38 -0700
From:   Alexei Starovoitov <>
To:     Andrii Nakryiko <>
Cc:     bpf <>,
        Network Development <>,
        Alexei Starovoitov <>,
        Daniel Borkmann <>,
        Andrii Nakryiko <>,
        Kernel Team <>, Yonghong Song <>
Subject: Re: [PATCH v2 bpf-next] bpf: fix bpf_iter's task iterator logic

On Wed, May 13, 2020 at 10:54 PM Andrii Nakryiko <> wrote:
> task_seq_get_next might stop prematurely if get_pid_task() fails to get
> task_struct. Failure to do so doesn't mean that there are no more tasks with
> higher pids. Procfs's iteration algorithm (see next_tgid in fs/proc/base.c)
> does a retry in such case. After this fix, instead of stopping prematurely
> after about 300 tasks on my server, bpf_iter program now returns >4000, which
> sounds much closer to reality.
> Cc: Yonghong Song <>
> Fixes: eaaacd23910f ("bpf: Add task and task/file iterator targets")
> Acked-by: Yonghong Song <>
> Signed-off-by: Andrii Nakryiko <>

Applied. Thanks

Powered by blists - more mailing lists