netdev - Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200516021157.GA6075@ns.kevlo.org>
Date:   Sat, 16 May 2020 10:11:57 +0800
From:   Kevin Lo <kevlo@...lo.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

On Fri, May 15, 2020 at 02:31:42PM -0700, Jakub Kicinski wrote:
> 
> On Sat, 16 May 2020 01:24:47 +0800 Kevin Lo wrote:
> > The BCM54811 PHY shares many similarities with the already supported BCM54810
> > PHY but additionally requires some semi-unique configuration.
> > 
> > Signed-off-by: Kevin Lo <kevlo@...lo.org>
> > Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Checkpatch complains about using spaces instead of tabs:
> 
> ERROR: code indent should use tabs where possible
> #80: FILE: drivers/net/phy/broadcom.c:359:
> +        }$

Thanks for spotting this out.  Will send the patch to fix it.