lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 May 2020 00:10:21 -0400 From: Rafael Aquini <aquini@...hat.com> To: Luis Chamberlain <mcgrof@...nel.org> Cc: jeyu@...nel.org, akpm@...ux-foundation.org, arnd@...db.de, rostedt@...dmis.org, mingo@...hat.com, cai@....pw, dyoung@...hat.com, bhe@...hat.com, peterz@...radead.org, tglx@...utronix.de, gpiccoli@...onical.com, pmladek@...e.com, tiwai@...e.de, schlad@...e.de, andriy.shevchenko@...ux.intel.com, keescook@...omium.org, daniel.vetter@...ll.ch, will@...nel.org, mchehab+samsung@...nel.org, kvalo@...eaurora.org, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Ariel Elior <aelior@...vell.com>, GR-everest-linux-l2@...vell.com, Igor Russkikh <irusskikh@...vell.com> Subject: Re: [PATCH v2 09/15] qed: use new module_firmware_crashed() On Fri, May 15, 2020 at 09:28:40PM +0000, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Ariel Elior <aelior@...vell.com> > Cc: GR-everest-linux-l2@...vell.com > Reviewed-by: Igor Russkikh <irusskikh@...vell.com> > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> > --- > drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c > index 9624616806e7..aea200d465ef 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c > @@ -566,6 +566,7 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn, > DP_NOTICE(p_hwfn, > "The MFW failed to respond to command 0x%08x [param 0x%08x].\n", > p_mb_params->cmd, p_mb_params->param); > + module_firmware_crashed(); > qed_mcp_print_cpu_info(p_hwfn, p_ptt); > > spin_lock_bh(&p_hwfn->mcp_info->cmd_lock); > -- > 2.26.2 > Acked-by: Rafael Aquini <aquini@...hat.com>
Powered by blists - more mailing lists