lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 May 2020 00:13:13 -0400 From: Rafael Aquini <aquini@...hat.com> To: Luis Chamberlain <mcgrof@...nel.org> Cc: jeyu@...nel.org, akpm@...ux-foundation.org, arnd@...db.de, rostedt@...dmis.org, mingo@...hat.com, cai@....pw, dyoung@...hat.com, bhe@...hat.com, peterz@...radead.org, tglx@...utronix.de, gpiccoli@...onical.com, pmladek@...e.com, tiwai@...e.de, schlad@...e.de, andriy.shevchenko@...ux.intel.com, keescook@...omium.org, daniel.vetter@...ll.ch, will@...nel.org, mchehab+samsung@...nel.org, kvalo@...eaurora.org, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, Arend van Spriel <arend.vanspriel@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, Rafał Miłecki <rafal@...ecki.pl>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com> Subject: Re: [PATCH v2 14/15] brcm80211: use new module_firmware_crashed() On Fri, May 15, 2020 at 09:28:45PM +0000, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: linux-wireless@...r.kernel.org > Cc: brcm80211-dev-list.pdl@...adcom.com > Cc: brcm80211-dev-list@...ress.com > Cc: Arend van Spriel <arend.vanspriel@...adcom.com> > Cc: Franky Lin <franky.lin@...adcom.com> > Cc: Hante Meuleman <hante.meuleman@...adcom.com> > Cc: Chi-Hsien Lin <chi-hsien.lin@...ress.com> > Cc: Wright Feng <wright.feng@...ress.com> > Cc: Kalle Valo <kvalo@...eaurora.org> > Cc: "Rafał Miłecki" <rafal@...ecki.pl> > Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com> > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > index c88655acc78c..d623f83568b3 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > @@ -1393,6 +1393,7 @@ void brcmf_fw_crashed(struct device *dev) > struct brcmf_pub *drvr = bus_if->drvr; > > bphy_err(drvr, "Firmware has halted or crashed\n"); > + module_firmware_crashed(); > > brcmf_dev_coredump(dev); > > -- > 2.26.2 > Acked-by: Rafael Aquini <aquini@...hat.com>
Powered by blists - more mailing lists