lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 May 2020 13:55:29 +0530 From: Vasundhara Volam <vasundhara-v.volam@...adcom.com> To: jeyu@...nel.org Cc: davem@...emloft.net, netdev@...r.kernel.org, michael.chan@...adcom.com, Vasundhara Volam <vasundhara-v.volam@...adcom.com>, Luis Chamberlain <mcgrof@...nel.org> Subject: [PATCH v2] bnxt_en: use new module_firmware_crashed() This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Luis Chamberlain <mcgrof@...nel.org> Reviewed-by: Michael Chan <michael.chan@...adcom.com> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com> --- v2: Move call module_firmware_crashed() to bnxt_fw_fatal_recover(). This will optimize to make the call at one central place. Please append to the patchset: ("[PATCH v2 00/15] net: taint when the device driver firmware crashes") --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index a812beb..1e37938 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -121,6 +121,7 @@ static int bnxt_fw_fatal_recover(struct devlink_health_reporter *reporter, if (!priv_ctx) return -EOPNOTSUPP; + module_firmware_crashed(); bp->fw_health->fatal = true; event = fw_reporter_ctx->sp_event; if (event == BNXT_FW_RESET_NOTIFY_SP_EVENT) -- 1.8.3.1
Powered by blists - more mailing lists