netdev - Re: [PATCH REPOST] net: dsa: mt7530: fix roaming from DSA user ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200516.135012.277283823891648494.davem@davemloft.net>
Date:   Sat, 16 May 2020 13:50:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dqfext@...il.com
Cc:     netdev@...r.kernel.org, sean.wang@...iatek.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        linux-mediatek@...ts.infradead.org, linux@...linux.org.uk,
        matthias.bgg@...il.com, opensource@...rst.com, tj17@...com,
        foss@...atilesystems.org, riddlariddla@...mail.com,
        szab.hu@...il.com, fercerpav@...il.com
Subject: Re: [PATCH REPOST] net: dsa: mt7530: fix roaming from DSA user
 ports

From: DENG Qingfang <dqfext@...il.com>
Date: Wed, 13 May 2020 23:10:16 +0800

> When a client moves from a DSA user port to a software port in a bridge,
> it cannot reach any other clients that connected to the DSA user ports.
> That is because SA learning on the CPU port is disabled, so the switch
> ignores the client's frames from the CPU port and still thinks it is at
> the user port.
> 
> Fix it by enabling SA learning on the CPU port.
> 
> To prevent the switch from learning from flooding frames from the CPU
> port, set skb->offload_fwd_mark to 1 for unicast and broadcast frames,
> and let the switch flood them instead of trapping to the CPU port.
> Multicast frames still need to be trapped to the CPU port for snooping,
> so set the SA_DIS bit of the MTK tag to 1 when transmitting those frames
> to disable SA learning.
> 
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> Signed-off-by: DENG Qingfang <dqfext@...il.com>

Applied and queued up for -stable, thanks.