netdev - Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200517210837.GL1370@kunai>
Date:   Sun, 17 May 2020 23:08:37 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Jens Axboe <axboe@...nel.dk>, Rob Herring <robh+dt@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "David S. Miller" <davem@...emloft.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>, linux-ide@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-mmc@...r.kernel.org,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-watchdog@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

On Fri, May 15, 2020 at 04:08:57PM +0100, Lad Prabhakar wrote:
> Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
> RZ/G1H (r8a7742) SoC.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@...renesas.com>

The DTS change looks fine, I checked it against similar SoCs (like the
previous patched). So, for that:

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

However, just to make sure, have you checked the WDT (especially reboot)
with SMP and multiple CPU cores enabled? Some early Gen2 SoCs had issues
there.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)