netdev - Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200517192628.GF606317@lunn.ch>
Date:   Sun, 17 May 2020 21:26:28 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Vasut <marex@...x.de>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        lukas@...ner.de, ynezz@...e.cz, yuehaibing@...wei.com
Subject: Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

> So I was already led into reworking the entire series to do this
> inlining once, after V1. It then turned out it's a horrible mess to get
> everything to compile as modules and built-in and then also only the
> parallel/SPI as a module and then the other way around.

Maybe consider some trade offs. Have both sets of accessors in the
core, and then thin wrappers around it to probe on each bus type. You
bloat the core, but avoid the indirection. You can also have the core
as a standalone module, which exports symbols for the wrappers to
use. It does take some Kconfig work to get built in vs modules
correct, but there are people who can help. It is also not considered
a regression if you reduce the options in terms of module vs built in.

   Andrew