netdev - Re: [PATCH net] net: phy: propagate an error back to the callers of phy_sfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200517.124415.2069030851463810409.davem@davemloft.net>
Date:   Sun, 17 May 2020 12:44:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     leon@...nel.org
Cc:     andrew@...n.ch, kuba@...nel.org, f.fainelli@...il.com,
        hkallweit1@...il.com, leonro@...lanox.com, netdev@...r.kernel.org,
        rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net] net: phy: propagate an error back to the callers
 of phy_sfp_probe

From: Leon Romanovsky <leon@...nel.org>
Date: Sun, 17 May 2020 14:53:40 +0300

> From: Leon Romanovsky <leonro@...lanox.com>
> 
> The compilation warning below reveals that the errors returned from
> the sfp_bus_add_upstream() call are not propagated to the callers.
> Fix it by returning "ret".
> 
> 14:37:51 drivers/net/phy/phy_device.c: In function 'phy_sfp_probe':
> 14:37:51 drivers/net/phy/phy_device.c:1236:6: warning: variable 'ret'
>    set but not used [-Wunused-but-set-variable]
> 14:37:51  1236 |  int ret;
> 14:37:51       |      ^~~
> 
> Fixes: 298e54fa810e ("net: phy: add core phylib sfp support")
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>

Applied, thank you.