netdev - Re: [PATCH bpf-next v2 0/5] samples: bpf: refactor kprobe tracing progs with libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13f1ba03-b3d7-891f-157b-09940eeb5279@fb.com>
Date:   Sun, 17 May 2020 22:05:39 -0700
From:   Yonghong Song <yhs@...com>
To:     "Daniel T. Lee" <danieltimlee@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>
CC:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf-next v2 0/5] samples: bpf: refactor kprobe tracing
 progs with libbpf



On 5/15/20 9:06 PM, Daniel T. Lee wrote:
> Currently, the kprobe BPF program attachment method for bpf_load is
> pretty outdated. The implementation of bpf_load "directly" controls and
> manages(create, delete) the kprobe events of DEBUGFS. On the other hand,
> using using the libbpf automatically manages the kprobe event.
> (under bpf_link interface)
> 
> This patchset refactors kprobe tracing programs with using libbpf API
> for loading bpf program instead of previous bpf_load implementation.
> 
> ---
> Changes in V2:
>   - refactor pointer error check with libbpf_get_error
>   - on bpf object open failure, return instead jump to cleanup
>   - add macro for adding architecture prefix to system calls (sys_*)
> 
> Daniel T. Lee (5):
>    samples: bpf: refactor pointer error check with libbpf
>    samples: bpf: refactor kprobe tracing user progs with libbpf
>    samples: bpf: refactor tail call user progs with libbpf
>    samples: bpf: add tracex7 test file to .gitignore
>    samples: bpf: refactor kprobe, tail call kern progs map definition
> 
>   samples/bpf/.gitignore              |  1 +
>   samples/bpf/Makefile                | 16 +++---- >   samples/bpf/sampleip_kern.c         | 12 +++---
>   samples/bpf/sampleip_user.c         |  7 +--
>   samples/bpf/sockex3_kern.c          | 36 ++++++++--------
>   samples/bpf/sockex3_user.c          | 64 +++++++++++++++++++---------
>   samples/bpf/trace_common.h          | 13 ++++++
>   samples/bpf/trace_event_kern.c      | 24 +++++------
>   samples/bpf/trace_event_user.c      |  9 ++--
>   samples/bpf/tracex1_user.c          | 37 +++++++++++++---
>   samples/bpf/tracex2_kern.c          | 27 ++++++------
>   samples/bpf/tracex2_user.c          | 51 ++++++++++++++++++----
>   samples/bpf/tracex3_kern.c          | 24 +++++------
>   samples/bpf/tracex3_user.c          | 61 +++++++++++++++++++-------
>   samples/bpf/tracex4_kern.c          | 12 +++---
>   samples/bpf/tracex4_user.c          | 51 +++++++++++++++++-----
>   samples/bpf/tracex5_kern.c          | 14 +++---
>   samples/bpf/tracex5_user.c          | 66 +++++++++++++++++++++++++----
>   samples/bpf/tracex6_kern.c          | 38 +++++++++--------
>   samples/bpf/tracex6_user.c          | 49 ++++++++++++++++++---
>   samples/bpf/tracex7_user.c          | 39 +++++++++++++----
>   samples/bpf/xdp_redirect_cpu_user.c |  5 +--
>   22 files changed, 455 insertions(+), 201 deletions(-)
>   create mode 100644 samples/bpf/trace_common.h

Thanks! LGTM. Ack for the whole series:
Acked-by: Yonghong Song <yhs@...com>