netdev - Re: [PATCH net-next 0/7] Raw PHY TDR data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200518093804.34a69fff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 18 May 2020 09:38:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH net-next 0/7] Raw PHY TDR data

On Sun, 17 May 2020 21:58:44 +0200 Andrew Lunn wrote:
> Some ethernet PHYs allow access to raw TDR data in addition to summary
> diagnostics information. Add support for retrieving this data via
> netlink ethtool. The basic structure in the core is the same as for
> normal phy diagnostics, the PHY driver simply uses different helpers
> to fill the netlink message with different data.
> 
> There is a graphical tool under development, as well a ethtool(1)
> which can dump the data as text and JSON.
> 
> Thanks for Chris Healy for lots of testing.

Hm, my system can't build this with allmodconfig:

drivers/net/phy/nxp-tja11xx.c:195:37: error: not enough arguments for function ethnl_cable_test_alloc
drivers/net/phy/nxp-tja11xx.c: In function tja11xx_config_aneg_cable_test:
drivers/net/phy/nxp-tja11xx.c:195:8: error: too few arguments to function ethnl_cable_test_alloc
  195 |  ret = ethnl_cable_test_alloc(phydev);
      |        ^~~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/net/phy/nxp-tja11xx.c:8:
include/linux/ethtool_netlink.h:30:19: note: declared here
   30 | static inline int ethnl_cable_test_alloc(struct phy_device *phydev, u8 cmd)
      |                   ^~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [drivers/net/phy/nxp-tja11xx.o] Error 1
make[3]: *** [drivers/net/phy] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [sub-make] Error 2