netdev - Re: [PATCH V6 16/20] net: ks8851: Implement register, FIFO, lock accessor callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200518102942.0d368e70@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 18 May 2020 10:29:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Lukas Wunner <lukas@...ner.de>, Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH V6 16/20] net: ks8851: Implement register, FIFO, lock
 accessor callbacks

On Mon, 18 May 2020 19:06:45 +0200 Marek Vasut wrote:
> On 5/18/20 6:34 PM, Jakub Kicinski wrote:
> > On Sun, 17 May 2020 02:33:50 +0200 Marek Vasut wrote:  
> >> The register and FIFO accessors are bus specific, so is locking.
> >> Implement callbacks so that each variant of the KS8851 can implement
> >> matching accessors and locking, and use the rest of the common code.
> >>
> >> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> >> Signed-off-by: Marek Vasut <marex@...x.de>
> >> Cc: David S. Miller <davem@...emloft.net>
> >> Cc: Lukas Wunner <lukas@...ner.de>
> >> Cc: Petr Stetiar <ynezz@...e.cz>
> >> Cc: YueHaibing <yuehaibing@...wei.com>  
> > 
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member '____cacheline_aligned' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'tx_space' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'lock' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'unlock' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdreg16' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrreg16' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdfifo' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrfifo' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'start_xmit' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rx_skb' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'flush_tx_work' not described in 'ks8851_net'
> > drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer1' not described in 'ks8851_net_spi'
> > drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer2' not described in 'ks8851_net_spi'
> > drivers/net/ethernet/micrel/ks8851.c:561: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb_spi'
> > drivers/net/ethernet/micrel/ks8851.c:570: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb'  
> 
> A lot of those were there already before this series 

I know, 4 out of the 15 above.

> they are in fact fixed by this series. The result builds clean with W=1 .

Excellent, fixing things is appreciated! It'd be great if new
warnings did not intermittently exist mid-series.