netdev - Re: unstable xdp tests. Was: [PATCH net-next v4 31/33] bpf: add xdp.frame_sz in bpf_prog_test_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 May 2020 12:19:15 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Yonghong Song <yhs@...com>, sameehj@...zon.com,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        John Fastabend <john.fastabend@...il.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        David Ahern <dsahern@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Andrii Nakryiko <andriin@...com>
Subject: Re: unstable xdp tests. Was: [PATCH net-next v4 31/33] bpf: add
 xdp.frame_sz in bpf_prog_test_run_xdp().

On Mon, May 18, 2020 at 3:33 AM Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
>
> On Mon, 18 May 2020 11:52:34 +0200
> Jesper Dangaard Brouer <brouer@...hat.com> wrote:
>
> > ... I'm getting unrelated compile errors for selftests/bpf in
> > bpf-next tree (HEAD 96586dd9268d2).
> >
> > The compile error, see below signature, happens in ./progs/bpf_iter_ipv6_route.c
> > (tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c).
> >
> > Related to commit:
> >  7c128a6bbd4f ("tools/bpf: selftests: Add iterator programs for ipv6_route and netlink") (Author: Yonghong Song)
>
> After re-compiling the kernel in the same tree, this issue goes away.
>
> I guess this is related to:
>   #include "vmlinux.h"
>

Yes, I ran into the same issue with libbpf CI tests for older kernel.
vmlinux.h for it simply doesn't contain definitions of bpf_iter__xxx
types. I think for selftests, it's better to have local copies of
those struct definitions, to make it compilable against older
vmlinux.h.


> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer
>