netdev - Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8t1yJF=2+N+g=doVgFpZmtiRaZX-d_1=KGuWa3zYv9uPw@mail.gmail.com>
Date:   Mon, 18 May 2020 10:16:06 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jens Axboe <axboe@...nel.dk>, Rob Herring <robh+dt@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "David S. Miller" <davem@...emloft.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>, linux-ide@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        linux-i2c@...r.kernel.org,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

Hi Wolfram,

On Sun, May 17, 2020 at 10:08 PM Wolfram Sang <wsa@...-dreams.de> wrote:
>
> On Fri, May 15, 2020 at 04:08:57PM +0100, Lad Prabhakar wrote:
> > Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
> > RZ/G1H (r8a7742) SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@...renesas.com>
>
> The DTS change looks fine, I checked it against similar SoCs (like the
> previous patched). So, for that:
>
> Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
>
Thank you for review.

> However, just to make sure, have you checked the WDT (especially reboot)
> with SMP and multiple CPU cores enabled? Some early Gen2 SoCs had issues
> there.
>
Its similar to as seen on Rcar-H2 where just the A15 cores are up and
A7 cores fail to boot. Attached is the boot log where reboot works as
expected with all A15 core up. Although I have tested the internal
release based on 3.10 where all the cores are up which used bootarg
apmu=multicluster (https://patchwork.kernel.org/patch/3948791/). So
there is some work involved to get all the A7's up and running.


Cheers,
--Prabhakar

View attachment "log.txt" of type "text/plain" (25436 bytes)