lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 20 May 2020 00:57:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        kuba@...nel.org, hawk@...nel.org, john.fastabend@...il.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        magnus.karlsson@...el.com, jonathan.lemon@...il.com,
        jeffrey.t.kirsher@...el.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Björn Töpel <bjorn.topel@...el.com>,
        maximmi@...lanox.com, maciej.fijalkowski@...el.com,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH bpf-next v3 07/15] i40e: separate kernel allocated rx_bi
 rings from AF_XDP rings

Hi "Björn,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]
[also build test WARNING on jkirsher-next-queue/dev-queue next-20200518]
[cannot apply to bpf/master linus/master v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-AF_XDP-buffer-allocation-API/20200519-203122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:531:6: warning: no previous prototype for function 'i40e_fd_handle_status' [-Wmissing-prototypes]
void i40e_fd_handle_status(struct i40e_ring *rx_ring, u64 qword0_raw,
^
drivers/net/ethernet/intel/i40e/i40e_txrx.c:531:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void i40e_fd_handle_status(struct i40e_ring *rx_ring, u64 qword0_raw,
^
static
1 warning generated.

vim +/i40e_fd_handle_status +531 drivers/net/ethernet/intel/i40e/i40e_txrx.c

   520	
   521	/**
   522	 * i40e_fd_handle_status - check the Programming Status for FD
   523	 * @rx_ring: the Rx ring for this descriptor
   524	 * @qword0_raw: qword0
   525	 * @qword1: qword1 after le_to_cpu
   526	 * @prog_id: the id originally used for programming
   527	 *
   528	 * This is used to verify if the FD programming or invalidation
   529	 * requested by SW to the HW is successful or not and take actions accordingly.
   530	 **/
 > 531	void i40e_fd_handle_status(struct i40e_ring *rx_ring, u64 qword0_raw,
   532				   u64 qword1, u8 prog_id)
   533	{
   534		struct i40e_pf *pf = rx_ring->vsi->back;
   535		struct pci_dev *pdev = pf->pdev;
   536		struct i40e_32b_rx_wb_qw0 *qw0;
   537		u32 fcnt_prog, fcnt_avail;
   538		u32 error;
   539	
   540		qw0 = (struct i40e_32b_rx_wb_qw0 *)&qword0_raw;
   541		error = (qword1 & I40E_RX_PROG_STATUS_DESC_QW1_ERROR_MASK) >>
   542			I40E_RX_PROG_STATUS_DESC_QW1_ERROR_SHIFT;
   543	
   544		if (error == BIT(I40E_RX_PROG_STATUS_DESC_FD_TBL_FULL_SHIFT)) {
   545			pf->fd_inv = le32_to_cpu(qw0->hi_dword.fd_id);
   546			if (qw0->hi_dword.fd_id != 0 ||
   547			    (I40E_DEBUG_FD & pf->hw.debug_mask))
   548				dev_warn(&pdev->dev, "ntuple filter loc = %d, could not be added\n",
   549					 pf->fd_inv);
   550	
   551			/* Check if the programming error is for ATR.
   552			 * If so, auto disable ATR and set a state for
   553			 * flush in progress. Next time we come here if flush is in
   554			 * progress do nothing, once flush is complete the state will
   555			 * be cleared.
   556			 */
   557			if (test_bit(__I40E_FD_FLUSH_REQUESTED, pf->state))
   558				return;
   559	
   560			pf->fd_add_err++;
   561			/* store the current atr filter count */
   562			pf->fd_atr_cnt = i40e_get_current_atr_cnt(pf);
   563	
   564			if (qw0->hi_dword.fd_id == 0 &&
   565			    test_bit(__I40E_FD_SB_AUTO_DISABLED, pf->state)) {
   566				/* These set_bit() calls aren't atomic with the
   567				 * test_bit() here, but worse case we potentially
   568				 * disable ATR and queue a flush right after SB
   569				 * support is re-enabled. That shouldn't cause an
   570				 * issue in practice
   571				 */
   572				set_bit(__I40E_FD_ATR_AUTO_DISABLED, pf->state);
   573				set_bit(__I40E_FD_FLUSH_REQUESTED, pf->state);
   574			}
   575	
   576			/* filter programming failed most likely due to table full */
   577			fcnt_prog = i40e_get_global_fd_count(pf);
   578			fcnt_avail = pf->fdir_pf_filter_count;
   579			/* If ATR is running fcnt_prog can quickly change,
   580			 * if we are very close to full, it makes sense to disable
   581			 * FD ATR/SB and then re-enable it when there is room.
   582			 */
   583			if (fcnt_prog >= (fcnt_avail - I40E_FDIR_BUFFER_FULL_MARGIN)) {
   584				if ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&
   585				    !test_and_set_bit(__I40E_FD_SB_AUTO_DISABLED,
   586						      pf->state))
   587					if (I40E_DEBUG_FD & pf->hw.debug_mask)
   588						dev_warn(&pdev->dev, "FD filter space full, new ntuple rules will not be added\n");
   589			}
   590		} else if (error == BIT(I40E_RX_PROG_STATUS_DESC_NO_FD_ENTRY_SHIFT)) {
   591			if (I40E_DEBUG_FD & pf->hw.debug_mask)
   592				dev_info(&pdev->dev, "ntuple filter fd_id = %d, could not be removed\n",
   593					 qw0->hi_dword.fd_id);
   594		}
   595	}
   596	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73478 bytes)

Powered by blists - more mailing lists