netdev - Re: [PATCH net-next 2/6] nexthop: support for fdb ecmp nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <530d85f9-7fd5-7e7b-7838-8ced98d27f3e@gmail.com>
Date:   Tue, 19 May 2020 11:07:49 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Petr Machata <petrm@...lanox.com>
Subject: Re: [PATCH net-next 2/6] nexthop: support for fdb ecmp nexthops

On 5/19/20 11:02 AM, Roopa Prabhu wrote:
> What are the rules here.... does neighbor code only check for NDA_NH_ID
> because the strict start type is set to NDA_NH_ID ?
> 

Lack of checking of unused attributes leads to the kernel silently
ignoring userspace data. From top of memory that has a few problems:

1. does the kernel support feature A (lack of probing for a feature),

2. kernel not implementing what the user requested and not telling the user,

3. impacting the ability to start using feature A in that code at some
point in the future (it was ignored in the past and garbage was passed
in, now suddenly that garbage is acted on).