netdev - Re: [PATCH net] mptcp: use rightmost 64 bits in ADD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200519.123935.2150930371716574515.davem@davemloft.net>
Date:   Tue, 19 May 2020 12:39:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     todd.malsbary@...ux.intel.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org, cpaasch@...le.com,
        matthieu.baerts@...sares.net
Subject: Re: [PATCH net] mptcp: use rightmost 64 bits in ADD_ADDR HMAC

From: Todd Malsbary <todd.malsbary@...ux.intel.com>
Date: Tue, 19 May 2020 09:45:34 -0700

> This changes the HMAC used in the ADD_ADDR option from the leftmost 64
> bits to the rightmost 64 bits as described in RFC 8684, section 3.4.1.
> 
> This issue was discovered while adding support to packetdrill for the
> ADD_ADDR v1 option.
> 
> Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
> Signed-off-by: Todd Malsbary <todd.malsbary@...ux.intel.com>
> Acked-by: Christoph Paasch <cpaasch@...le.com>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Applied, thanks.