netdev - RE: [net-next v5 4/9] igc: Use netdev log helpers in igc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 May 2020 01:35:30 +0000
From:   "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:     Joe Perches <joe@...ches.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "Guedes, Andre" <andre.guedes@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>
Subject: RE: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c

> -----Original Message-----
> From: Joe Perches <joe@...ches.com>
> Sent: Monday, May 18, 2020 18:22
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; davem@...emloft.net
> Cc: Guedes, Andre <andre.guedes@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; Brown, Aaron F
> <aaron.f.brown@...el.com>
> Subject: Re: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c
> 
> On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> > This patch converts all dev_* calls to netdev_*.
> []
> > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> []
> > @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device
> *netdev,
> >  	bool if_running = netif_running(netdev);
> >
> >  	if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
> > -		netdev_info(adapter->netdev, "offline testing starting");
> > +		netdev_info(adapter->netdev, "Offline testing starting");
> 
> several missing '\n' format terminations
[Kirsher, Jeffrey T] 

Your right, these never had them, which is why it was not caught.  I am fine with adding the terminating \n, if that is what is requested.  Andre was just trying to fix the message to properly capitalize the first letter of the message.

> 
> 		netdev_info(adapter->netdev, "Offline testing starting\n");
> 
> >  		set_bit(__IGC_TESTING, &adapter->state);
> >
> >  		/* Link test performed before hardware reset so autoneg doesn't
> @@
> > -1918,13 +1919,13 @@ static void igc_diag_test(struct net_device *netdev,
> >  		else
> >  			igc_reset(adapter);
> >
> > -		netdev_info(adapter->netdev, "register testing starting");
> > +		netdev_info(adapter->netdev, "Register testing starting");
> 
> etc...
[Kirsher, Jeffrey T] 

Yep here too