netdev - Re: [net-next 0/5] ip6_tunnel: add MPLS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad59aa7e-0c53-3046-a7b0-0932a1828aa1@novek.ru>
Date:   Wed, 20 May 2020 02:30:11 +0300
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     David Miller <davem@...emloft.net>
Cc:     kuznet@....inr.ac.ru, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [net-next 0/5] ip6_tunnel: add MPLS support

On 20.05.2020 01:34, David Miller wrote:
> From: Vadim Fedorenko <vfedorenko@...ek.ru>
> Date: Mon, 18 May 2020 23:33:43 +0300
>
>> The support for MPLS-in-IPv4 was added earlier. This patchset adds
>> support for MPLS-in-IPv6.
> This adds way too many ifdefs into the C code, please find another way
> to abstract this such that you don't need to add ifdefs all over the
> place.
>
> Thank you.

This patchset was based on support for MPLS in ipip tunnel which is full
of ifdefs. Can you suggest me a way to eliminate them?

I think that almost all code can be compiled without any ifdef because it
uses constants that are always defined execpt the init/deinit code. The
only way I see is to check presence of AF_MPLS at runtime but I don't know
how to do it right.

Thanks.