netdev - Re: [PATCH bpf-next] selftest/bpf: make bpf_iter selftest compilable against old vmlinux.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 May 2020 09:01:25 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Yonghong Song <yhs@...com>
Cc:     Andrii Nakryiko <andriin@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>,
        <andrii.nakryiko@...il.com>, <kernel-team@...com>,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next] selftest/bpf: make bpf_iter selftest
 compilable against old vmlinux.h

On Mon, 18 May 2020 18:42:24 -0700
Yonghong Song <yhs@...com> wrote:

> On 5/18/20 4:45 PM, Andrii Nakryiko wrote:
> > It's good to be able to compile bpf_iter selftest even on systems that don't
> > have the very latest vmlinux.h, e.g., for libbpf tests against older kernels in
> > Travis CI. To that extent, re-define bpf_iter_meta and corresponding bpf_iter
> > context structs in each selftest. To avoid type clashes with vmlinux.h, rename
> > vmlinux.h's definitions to get them out of the way.
> > 
> > Cc: Jesper Dangaard Brouer <brouer@...hat.com>
> > Cc: Yonghong Song <yhs@...com>
> > Signed-off-by: Andrii Nakryiko <andriin@...com>  
> 
> Acked-by: Yonghong Song <yhs@...com>

Thanks for looking into this Andrii :-)

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer