netdev - Re: [RDMA RFC v6 14/16] RDMA/irdma: Add ABI definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0240054-7a5c-5698-d213-b2070756c846@amazon.com>
Date:   Wed, 20 May 2020 12:02:35 +0300
From:   Gal Pressman <galpress@...zon.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, <dledford@...hat.com>,
        <jgg@...lanox.com>, <davem@...emloft.net>,
        Mustafa Ismail <mustafa.ismail@...el.com>,
        <linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
        <nhorman@...hat.com>, <sassmann@...hat.com>, <poswald@...e.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>
Subject: Re: [RDMA RFC v6 14/16] RDMA/irdma: Add ABI definitions

On 20/05/2020 11:52, Greg KH wrote:
> On Wed, May 20, 2020 at 10:54:25AM +0300, Gal Pressman wrote:
>> On 20/05/2020 10:04, Jeff Kirsher wrote:
>>> +struct i40iw_create_qp_resp {
>>> +   __u32 qp_id;
>>> +   __u32 actual_sq_size;
>>> +   __u32 actual_rq_size;
>>> +   __u32 i40iw_drv_opt;
>>> +   __u16 push_idx;
>>> +   __u8 lsmm;
>>> +   __u8 rsvd;
>>> +};
>>
>> This struct size should be 8 bytes aligned.
> 
> Aligned in what way?  Seems sane to me, what would you want it to look
> like instead?

The uverbs ABI structs sizes are assumed to be padded to 8 bytes alignment, I
would expect the reserved field to be an array of 5 bytes as done in other
structs in this file (irdma_modify_qp_req for example).
Jason could correct me if I'm wrong?