netdev - Re: [PATCH net-next v2 5/5] selftests: net: add fdb nexthop tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16c3de2b-2792-603d-4b3b-aa016a5f7538@gmail.com>
Date:   Wed, 20 May 2020 08:58:35 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
        jiri@...lanox.com, idosch@...lanox.com, petrm@...lanox.com
Subject: Re: [PATCH net-next v2 5/5] selftests: net: add fdb nexthop tests

On 5/19/20 10:33 PM, Roopa Prabhu wrote:
> +ipv6_fdb_grp_fcnal()
> +{
> +	local rc
> +
> +	echo
> +	echo "IPv6 fdb groups functional"
> +	echo "--------------------------"
> +
> +	check_nexthop_fdb_support
> +	if [ $? -eq $ksft_skip ]; then
> +		return $ksft_skip
> +	fi
> +
> +	# create group with multiple nexthops
> +	run_cmd "$IP nexthop add id 61 via 2001:db8:91::2 fdb"
> +	run_cmd "$IP nexthop add id 62 via 2001:db8:91::3 fdb"
> +	run_cmd "$IP nexthop add id 102 group 61/62 fdb"
> +	check_nexthop "id 102" "id 102 group 61/62 fdb"
> +	log_test $? 0 "Fdb Nexthop group with multiple nexthops"
> +
> +	## get nexthop group
> +	run_cmd "$IP nexthop get id 102"
> +	check_nexthop "id 102" "id 102 group 61/62 fdb"
> +	log_test $? 0 "Get Fdb nexthop group by id"
> +
> +	# fdb nexthop group can only contain fdb nexthops
> +	run_cmd "$IP nexthop add id 63 via 2001:db8:91::4"
> +	run_cmd "$IP nexthop add id 64 via 2001:db8:91::5"
> +	run_cmd "$IP nexthop add id 103 group 63/64 fdb"
> +	log_test $? 2 "Fdb Nexthop group with non-fdb nexthops"
> +
> +	# Non fdb nexthop group can not contain fdb nexthops
> +	run_cmd "$IP nexthop add id 65 via 2001:db8:91::5 fdb"
> +	run_cmd "$IP nexthop add id 66 via 2001:db8:91::6 fdb"
> +	run_cmd "$IP nexthop add id 104 group 65/66"
> +	log_test $? 2 "Non-Fdb Nexthop group with non nexthops"

Typo "non nexthops" should be "fdb nexthops"

...

> +
> +ipv4_fdb_grp_fcnal()
> +{
> +	local rc
> +
> +	echo
> +	echo "IPv4 fdb groups functional"
> +	echo "--------------------------"
> +
> +	check_nexthop_fdb_support
> +	if [ $? -eq $ksft_skip ]; then
> +		return $ksft_skip
> +	fi
> +
> +	# create group with multiple nexthops
> +	run_cmd "$IP nexthop add id 12 via 172.16.1.2 fdb"
> +	run_cmd "$IP nexthop add id 13 via 172.16.1.3 fdb"
> +	run_cmd "$IP nexthop add id 102 group 12/13 fdb"
> +	check_nexthop "id 102" "id 102 group 12/13 fdb"
> +	log_test $? 0 "Fdb Nexthop group with multiple nexthops"
> +
> +	# get nexthop group
> +	run_cmd "$IP nexthop get id 102"
> +	check_nexthop "id 102" "id 102 group 12/13 fdb"
> +	log_test $? 0 "Get Fdb nexthop group by id"
> +
> +	# fdb nexthop group can only contain fdb nexthops
> +	run_cmd "$IP nexthop add id 14 via 172.16.1.2"
> +	run_cmd "$IP nexthop add id 15 via 172.16.1.3"
> +	run_cmd "$IP nexthop add id 103 group 14/15 fdb"
> +	log_test $? 2 "Fdb Nexthop group with non-fdb nexthops"
> +
> +	# Non fdb nexthop group can not contain fdb nexthops
> +	run_cmd "$IP nexthop add id 16 via 172.16.1.2 fdb"
> +	run_cmd "$IP nexthop add id 17 via 172.16.1.3 fdb"
> +	run_cmd "$IP nexthop add id 104 group 14/15"
> +	log_test $? 2 "Non-Fdb Nexthop group with non nexthops"

same here

Reviewed-by: David Ahern <dsahern@...il.com>