netdev - Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200520095430.05cffcee@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 20 May 2020 09:54:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     fugang.duan@....com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        martin.fuzzey@...wbird.group, robh+dt@...nel.org,
        shawnguo@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset
 and bit into DT

On Wed, 20 May 2020 16:31:53 +0800 fugang.duan@....com wrote:
> From: Fugang Duan <fugang.duan@....com>
> 
> The commit da722186f654(net: fec: set GPR bit on suspend by DT
> configuration) set the GPR reigster offset and bit in driver for
> wake on lan feature.
> 
> But it introduces two issues here:
> - one SOC has two instances, they have different bit
> - different SOCs may have different offset and bit
> 
> So to support wake-on-lan feature on other i.MX platforms, it should
> configure the GPR reigster offset and bit from DT.
> 
> Fixes: da722186f654(net: fec: set GPR bit on suspend by DT configuration)
> Signed-off-by: Fugang Duan <fugang.duan@....com>

Fixes tag: Fixes: da722186f654(net: fec: set GPR bit on suspend by DT configuration)
Has these problem(s):
	- missing space between the SHA1 and the subject