netdev - Re: [PATCH v3 net-next] net: flow_offload: simplify hw stats check handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2586a0e-fce1-cee9-e2dc-f3dc73500515@solarflare.com>
Date:   Wed, 20 May 2020 18:31:05 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
        <jiri@...nulli.us>, <kuba@...nel.org>, <pablo@...filter.org>
Subject: Re: [PATCH v3 net-next] net: flow_offload: simplify hw stats check
 handling

On 20/05/2020 18:21, Edward Cree wrote:
> @@ -582,7 +590,7 @@ nf_flow_offload_rule_alloc(struct net *net,
>  	const struct flow_offload_tuple *tuple;
>  	struct nf_flow_rule *flow_rule;
>  	struct dst_entry *other_dst;
> -	int err = -ENOMEM;
> +	int err = -ENOMEM, i;
>  
>  	flow_rule = kzalloc(sizeof(*flow_rule), GFP_KERNEL);
>  	if (!flow_rule)
Whoops, this changebar isn't meant to be there.  Somehow I missed
 the unused var warning when I built it, too.
Drop this, I'll spin v4.