netdev - Re: [PATCH] net: nlmsg_cancel() if put fails for nhmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb7c50c5-b077-5413-0a6d-fe7f387df55d@gmail.com>
Date:   Tue, 19 May 2020 20:53:58 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Worley <sworley@...ulusnetworks.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, sharpd@...ulusnetworks.com,
        anuradhak@...ulusnetworks.com, roopa@...ulusnetworks.com,
        sworley1995@...il.com
Subject: Re: [PATCH] net: nlmsg_cancel() if put fails for nhmsg

On 5/19/20 7:57 PM, Stephen Worley wrote:
> Fixes data remnant seen when we fail to reserve space for a
> nexthop group during a larger dump.
> 
> If we fail the reservation, we goto nla_put_failure and
> cancel the message.
> 
> Reproduce with the following iproute2 commands:
> =====================
...
> Fixes: ab84be7e54fc ("net: Initial nexthop code")
> Signed-off-by: Stephen Worley <sworley@...ulusnetworks.com>
> ---
>  net/ipv4/nexthop.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: David Ahern <dsahern@...il.com>

Thanks, Stephen.