netdev - Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202005210746.cJP6yTY2%lkp@intel.com>
Date:   Thu, 21 May 2020 07:18:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Igor Russkikh <irusskikh@...vell.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bezrukov <dbezrukov@...vell.com>,
        Igor Russkikh <irusskikh@...vell.com>
Subject: Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC
 support

Hi Igor,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20200519]
[cannot apply to net/master linus/master ipvs/master v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-atlantic-QoS-implementation/20200521-033933
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4f65e2f483b6f764c15094d14dd53dda048a4048
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:951:14: warning: no previous prototype for 'ptp_ring_idx' [-Wmissing-prototypes]
951 | unsigned int ptp_ring_idx(const enum aq_tc_mode tc_mode)
|              ^~~~~~~~~~~~

vim +/ptp_ring_idx +951 drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

   947	
   948	/* Index must be 8 (8 TCs) or 16 (4 TCs).
   949	 * It depends on Traffic Class mode.
   950	 */
 > 951	unsigned int ptp_ring_idx(const enum aq_tc_mode tc_mode)
   952	{
   953		if (tc_mode == AQ_TC_MODE_8TCS)
   954			return PTP_8TC_RING_IDX;
   955	
   956		return PTP_4TC_RING_IDX;
   957	}
   958	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61386 bytes)