netdev - Re: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 May 2020 23:38:53 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Mark Starovoytov <mstarovoitov@...vell.com>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Dmitry Bezrukov" <dbezrukov@...vell.com>
Subject: Re: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for
 multi-TC support


>> Right now we really aren't sure we can dynamically rearrange
>> resources between QoS and PTP, since disabling/enabling PTP requires
>> a complete HW reconfiguration unfortunately. Even more unfortunate is
>> the fact that we can't change the TC, which is reserved for PTP,
>> because TC2 is hardcoded in firmware.
>>
>> We would prefer to keep things as is for now, if possible. We'll
>> discuss this with HW/FW team(s) and submit a follow-up patch, if we
>> find a way to automatically choose the config.
> 
> Module parameters are very strongly discouraged for networking drivers.
> They also constitute uAPI, and can't be changed, short-term solution
> like that is really far from ideal.

Thanks, Jakub.

Mark, Dmitry, lets try eliminating this parameter. Even if that'll cause some
limitations now - we can think how to dynamically handle these in future.

Regards,
  Igor