netdev - Re: [PATCH net-next] net/tls: fix race condition causing kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200521144030.201a4f22@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 21 May 2020 14:40:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vinay Kumar Yadav <vinay.yadav@...lsio.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        secdev@...lsio.com
Subject: Re: [PATCH net-next] net/tls: fix race condition causing kernel
 panic

On Fri, 22 May 2020 02:02:10 +0530 Vinay Kumar Yadav wrote:
> When writer reads pending == 0,
> that means completion is already called complete().
> its okay writer to  initialize completion. When writer reads pending == 1,
> that means writer is going to wait for completion.
> 
> This way, writer is not going to proceed to encrypt next record on CPU0 without complete().

I assume by writer you mean the CPU queuing up the records.

The writer does not wait between records, just before returning to user
space. The writer can queue multiple records then wait.