netdev - Re: Re: [PATCH] wlcore: fix runtime pm imbalance in wl1271_op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62e69631.b9cff.1723592e191.Coremail.dinghao.liu@zju.edu.cn>
Date:   Thu, 21 May 2020 12:51:57 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Tony Lindgren" <tony@...mide.com>
Cc:     kjlu@....edu, "Kalle Valo" <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Johannes Berg" <johannes.berg@...el.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Maital Hahn" <maitalm@...com>,
        "Fuqian Huang" <huangfq.daxian@...il.com>,
        "Emmanuel Grumbach" <emmanuel.grumbach@...el.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] wlcore: fix runtime pm imbalance in
 wl1271_op_suspend

There is a check against ret after out_sleep tag. If wl1271_configure_suspend_ap()
returns an error code, ret will be caught by this check and a warning will be issued.


&quot;Tony Lindgren&quot; &lt;tony@...mide.com&gt;写道：
> * Dinghao Liu <dinghao.liu@....edu.cn> [200520 12:58]:
> > When wlcore_hw_interrupt_notify() returns an error code,
> > a pairing runtime PM usage counter decrement is needed to
> > keep the counter balanced.
> 
> We should probably keep the warning though, nothing will
> get shown for wl1271_configure_suspend_ap() errors.
> 
> Otherwise looks good to me.
> 
> Regards,
> 
> Tony