netdev - Re: [PATCH net] ethtool: count header size in reply size estimate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200521.170031.935733729746615266.davem@davemloft.net>
Date:   Thu, 21 May 2020 17:00:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     kuba@...nel.org, netdev@...r.kernel.org, o.rempel@...gutronix.de
Subject: Re: [PATCH net] ethtool: count header size in reply size estimate

From: Michal Kubecek <mkubecek@...e.cz>
Date: Sun, 10 May 2020 21:04:09 +0200

> As ethnl_request_ops::reply_size handlers do not include common header
> size into calculated/estimated reply size, it needs to be added in
> ethnl_default_doit() and ethnl_default_notify() before allocating the
> message. On the other hand, strset_reply_size() should not add common
> header size.
> 
> Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
> Reported-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

"May 10th" :-)

Applied and queued up for -stable, thanks.