netdev - RE: [PATCH V1 net-next 05/15] net: ena: add prints to failed commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 09:09:48 +0000
From:   "Kiyanovski, Arthur" <akiyano@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>,
        "Agroskin, Shay" <shayagr@...zon.com>,
        "Jubran, Samih" <sameehj@...zon.com>
Subject: RE: [PATCH V1 net-next 05/15] net: ena: add prints to failed commands

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Friday, May 22, 2020 1:00 AM
> To: Kiyanovski, Arthur <akiyano@...zon.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Woodhouse, David
> <dwmw@...zon.co.uk>; Machulsky, Zorik <zorik@...zon.com>;
> Matushevsky, Alexander <matua@...zon.com>; Bshara, Saeed
> <saeedb@...zon.com>; Wilson, Matt <msw@...zon.com>; Liguori, Anthony
> <aliguori@...zon.com>; Bshara, Nafea <nafea@...zon.com>; Tzalik, Guy
> <gtzalik@...zon.com>; Belgazal, Netanel <netanel@...zon.com>; Saidi, Ali
> <alisaidi@...zon.com>; Herrenschmidt, Benjamin <benh@...zon.com>;
> Dagan, Noam <ndagan@...zon.com>; Agroskin, Shay
> <shayagr@...zon.com>; Jubran, Samih <sameehj@...zon.com>
> Subject: RE: [PATCH V1 net-next 05/15] net: ena: add prints to
> failed commands
>  
> 
> 
> On Thu, 21 May 2020 22:08:24 +0300 akiyano@...zon.com wrote:
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > index a014f514c069..f0b90e1551a3 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > @@ -175,8 +175,10 @@ static int ena_com_close_bounce_buffer(struct
> ena_com_io_sq *io_sq)
> >       if (pkt_ctrl->idx) {
> >               rc = ena_com_write_bounce_buffer_to_dev(io_sq,
> >                                                       pkt_ctrl->curr_bounce_buf);
> > -             if (unlikely(rc))
> > +             if (unlikely(rc)) {
> > +                     pr_err("failed to write bounce buffer to
> > + device\n");
> 
> Could you use dev_err() or even better netdev_err() to give users an idea which
> device is misbehaving?
> 
> >                       return rc;
> > +             }
> >
> >               pkt_ctrl->curr_bounce_buf =
> >
> > ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);

Yes, you're right, that would be better.
I'll remove this patch from the patchset, rework it, and submit it again in a future patchset.
Thanks!