lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 May 2020 13:11:16 +0300 From: Kalle Valo <kvalo@...eaurora.org> To: YueHaibing <yuehaibing@...wei.com> Cc: <nbd@....name>, <lorenzo.bianconi83@...il.com>, <ryder.lee@...iatek.com>, <davem@...emloft.net>, <kuba@...nel.org>, <matthias.bgg@...il.com>, <shayne.chen@...iatek.com>, <chih-min.chen@...iatek.com>, <yf.luo@...iatek.com>, <yiwei.chung@...iatek.com>, <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -next] mt76: mt7915: Fix build error YueHaibing <yuehaibing@...wei.com> writes: > In file included from ./include/linux/firmware.h:6:0, > from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: > In function ‘__mt7915_mcu_msg_send’, > inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: > ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^~~~~~ > ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^~~~~~~~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’ > BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS && > ^~~~~~~~~~~~ > > BUILD_BUG_ON is meaningless here, chang it to WARN_ON. > > Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") > Signed-off-by: YueHaibing <yuehaibing@...wei.com> I'm curious why I don't see this build error? I was about to send a pull request to Dave, should I hold off the pull request due to this problem? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists