netdev - Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200522151010.GC26949@breakpoint.cc>
Date:   Fri, 22 May 2020 17:10:10 +0200
From:   Florian Westphal <fw@...len.de>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        matthieu.baerts@...sares.net, mathew.j.martineau@...ux.intel.com
Subject: Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs
 from ssk to sk queue

Paolo Abeni <pabeni@...hat.com> wrote:
> It looks like this way ssk rcvbuf will grow up to tcp_rmem[2] even if
> there is no user-space reader - assuming the link is fast enough.
> 
> Don't we need to somehow cap that? e.g. moving mptcp rcvbuf update in
> mptcp_revmsg()?

>From irc discussion it looks like you already have a patch for that.

I marked this patch as "Changes Requested" and do not plan to resend
it for the time being.