netdev - Re: [PATCH v2 net-next 00/12] net: atlantic: QoS implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200522105857.759e7589@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 22 May 2020 10:58:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>,
        Mark Starovoytov <mstarovoitov@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 net-next 00/12] net: atlantic: QoS implementation

On Fri, 22 May 2020 11:19:36 +0300 Igor Russkikh wrote:
> This patch series adds support for mqprio rate limiters and multi-TC:
>  * max_rate is supported on both A1 and A2;
>  * min_rate is supported on A2 only;
> 
> This is a joint work of Mark and Dmitry.
> 
> To implement this feature, a couple of rearrangements and code
> improvements were done, in areas of TC/ring management, allocation
> control, etc.
> 
> One of the problems we faced is conflicting ptp functionality, which
> consumes a whole traffic class due to hardware limitations.
> Patches below have a more detailed description on how PTP and multi-TC
> co-exist right now.
> 
> v2:
>  * accommodated review comments (-Wmissing-prototypes and
>    -Wunused-but-set-variable findings);
>  * added user notification in case of conflicting multi-TC<->PTP
>    configuration;
>  * added automatic PTP disabling, if a conflicting configuration is
>    detected;
>  * removed module param, which was used for PTP disabling in v1;
> 
> v1: https://patchwork.ozlabs.org/cover/1294380/

Acked-by: Jakub Kicinski <kuba@...nel.org>