netdev - Re: [PATCH net] mptcp: use untruncated hash in ADD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200522.142211.889204416624218899.davem@davemloft.net>
Date:   Fri, 22 May 2020 14:22:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     todd.malsbary@...ux.intel.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org, cpaasch@...le.com,
        mathew.j.martineau@...ux.intel.com
Subject: Re: [PATCH net] mptcp: use untruncated hash in ADD_ADDR HMAC

From: Todd Malsbary <todd.malsbary@...ux.intel.com>
Date: Thu, 21 May 2020 19:10:49 -0700

> There is some ambiguity in the RFC as to whether the ADD_ADDR HMAC is
> the rightmost 64 bits of the entire hash or of the leftmost 160 bits
> of the hash.  The intention, as clarified with the author of the RFC,
> is the entire hash.
> 
> This change returns the entire hash from
> mptcp_crypto_hmac_sha (instead of only the first 160 bits), and moves
> any truncation/selection operation on the hash to the caller.
> 
> Fixes: 12555a2d97e5 ("mptcp: use rightmost 64 bits in ADD_ADDR HMAC")
> Reviewed-by: Christoph Paasch <cpaasch@...le.com>
> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Todd Malsbary <todd.malsbary@...ux.intel.com>

Applied, thank you.