netdev - Re: [PATCH net] felix: Fix initialization of ioremap resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200522.142628.1582912241162372403.davem@davemloft.net>
Date:   Fri, 22 May 2020 14:26:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org, vladimir.oltean@....com
Subject: Re: [PATCH net] felix: Fix initialization of ioremap resources

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Fri, 22 May 2020 11:54:34 +0300

> The caller of devm_ioremap_resource(), either accidentally
> or by wrong assumption, is writing back derived resource data
> to global static resource initialization tables that should
> have been constant.  Meaning that after it computes the final
> physical start address it saves the address for no reason
> in the static tables.  This doesn't affect the first driver
> probing after reboot, but it breaks consecutive driver reloads
> (i.e. driver unbind & bind) because the initialization tables
> no longer have the correct initial values.  So the next probe()
> will map the device registers to wrong physical addresses,
> causing ARM SError async exceptions.
> This patch fixes all of the above.
> 
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied and queued up for -stable, thanks.