netdev - Re: [PATCH] net: sgi: ioc3-eth: Fix return value check in ioc3eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 May 2020 17:27:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tangbin@...s.chinamobile.com
Cc:     ralf@...ux-mips.org, paulburton@...nel.org, tbogendoerfer@...e.de,
        linux-mips@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH] net: sgi: ioc3-eth: Fix return value check in
 ioc3eth_probe()

From: Tang Bin <tangbin@...s.chinamobile.com>
Date: Wed, 20 May 2020 17:55:32 +0800

> In the function devm_platform_ioremap_resource(), if get resource
> failed, the return value is ERR_PTR() not NULL. Thus it must be
> replaced by IS_ERR(), or else it may result in crashes if a critical
> error path is encountered.
> 
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Applied, thanks.