netdev - Re: [PATCH net] net: mvpp2: fix RX hashing for non-10G ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 15:32:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     maxime.chevallier@...tlin.com, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: mvpp2: fix RX hashing for non-10G ports

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Wed, 20 May 2020 12:26:35 +0100

> When rxhash is enabled on any ethernet port except the first in each CP
> block, traffic flow is prevented.  The analysis is below:
 ...
> So, this patch attempts to solve the issue by clearing the
> MVPP2_CLS_SWFWD_PCTRL_MASK() bit, allowing MVPP22_CLS_C2_ATTR0_QHIGH()
> from the classifier to define the queue-high field of the queue number.
> 
> My testing seems to confirm my findings above - clearing this bit
> means that if I enable rxhash on eth2, the interface can then pass
> traffic, as we are now directing traffic to RX queue 1 rather than
> queue 33. Traffic still seems to work with rxhash off as well.
> 
> Reported-by: Matteo Croce <mcroce@...hat.com>
> Tested-by: Matteo Croce <mcroce@...hat.com>
> Fixes: 895586d5dc32 ("net: mvpp2: cls: Use RSS contexts to handle RSS tables")
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied and queued up for -stable, thanks Russell.