netdev - Re: [PATCH net] net: mscc: ocelot: fix address ageing time (again)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200522.161601.1692050662918253992.davem@davemloft.net>
Date:   Fri, 22 May 2020 16:16:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     netdev@...r.kernel.org, allan.nielsen@...rochip.com,
        horatiu.vultur@...rochip.com, andrew@...n.ch, f.fainelli@...il.com,
        vivien.didelot@...il.com, joergen.andreasen@...rochip.com,
        claudiu.manoil@....com, UNGLinuxDriver@...rochip.com,
        alexandru.marginean@....com, xiaoliang.yang_1@....com,
        yangbo.lu@....com, po.liu@....com
Subject: Re: [PATCH net] net: mscc: ocelot: fix address ageing time (again)

From: Vladimir Oltean <olteanv@...il.com>
Date: Fri, 22 May 2020 00:31:23 +0300

> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> ocelot_set_ageing_time has 2 callers:
>  - felix_set_ageing_time: from drivers/net/dsa/ocelot/felix.c
>  - ocelot_port_attr_ageing_set: from drivers/net/ethernet/mscc/ocelot.c
> 
> The issue described in the fixed commit below actually happened for the
> felix_set_ageing_time code path only, since ocelot_port_attr_ageing_set
> was already dividing by 1000. So to make both paths symmetrical (and to
> fix addresses getting aged way too fast on Ocelot), stop dividing by
> 1000 at caller side altogether.
> 
> Fixes: c0d7eccbc761 ("net: mscc: ocelot: ANA_AUTOAGE_AGE_PERIOD holds a value in seconds, not ms")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied.