lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 May 2020 08:30:41 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Qiushi Wu <wu000273@....edu>, linux-afs@...ts.infradead.org, netdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Kangjie Lu <kjlu@....edu> Subject: Re: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response() > In function rxkad_verify_response(), pointer "ticket" is not released, > when function rxkad_decrypt_ticket() returns an error, causing a > memory leak bug. I suggest to improve also this change description. How do you think about a wording variant like the following? A ticket was not released after a call of the function “platform_get_irq” failed. Thus replace the jump target “temporary_error_free_resp” by “temporary_error_free_ticket”. Regards, Markus
Powered by blists - more mailing lists