netdev - Re: [PATCH] Fix various coding-style issues and improve printk() usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200523125755.65457014@hermes.lan>
Date:   Sat, 23 May 2020 12:57:55 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Armin Wolf <W_Armin@....de>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix various coding-style issues and improve printk()
 usage

On Sat, 23 May 2020 18:06:44 +0200
Armin Wolf <W_Armin@....de> wrote:

>  /* These identify the driver base version and may not be removed. */
>  static const char version[] =
> -	KERN_INFO DRV_NAME ".c:v" DRV_VERSION " " DRV_RELDATE
> -	" D. Becker/P. Gortmaker\n";
> +	"Version " DRV_VERSION " " DRV_RELDATE " D. Becker/P. Gortmaker\n";

This is how Linux drivers behaved years ago, it is bad practice now.