netdev - Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200523.162612.1919894290900733612.davem@davemloft.net>
Date:   Sat, 23 May 2020 16:26:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michael@...le.cc
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, kuba@...nel.org, ujhelyi.m@...il.com
Subject: Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks

From: Michael Walle <michael@...le.cc>
Date: Fri, 22 May 2020 11:53:31 +0200

> Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the
> PHY ID mask was set to 0xffffffef. It is unclear to me why this mask was
> chosen in the first place. Both the AR8031/AR8033 and the AR8035
> datasheets mention it is always the given value:
>  - for AR8031/AR8033 its 0x004d/0xd074
>  - for AR8035 its 0x004d/0xd072
> 
> Unfortunately, I don't have a datasheet for the AR8030. Therefore, we
> leave its PHY ID mask untouched. For the PHYs mentioned before use the
> handy PHY_ID_MATCH_EXACT() macro.
> 
> I've tried to contact the author of the initial commit, but received no
> answer so far.
> 
> Cc: Matus Ujhelyi <ujhelyi.m@...il.com>
> Signed-off-by: Michael Walle <michael@...le.cc>

Applied, thank you.