netdev - Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200523.163519.974222011620661089.davem@davemloft.net>
Date:   Sat, 23 May 2020 16:35:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     grygorii.strashko@...com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, nsekhar@...com,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        s-anna@...com
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning
 during suspend

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Fri, 22 May 2020 19:39:31 +0300

> vlan_for_each() are required to be called with rtnl_lock taken, otherwise
> ASSERT_RTNL() warning will be triggered - which happens now during System
> resume from suspend:
>   cpsw_suspend()
>   |- cpsw_ndo_stop()
>     |- __hw_addr_ref_unsync_dev()
>       |- cpsw_purge_all_mc()
>          |- vlan_for_each()
>             |- ASSERT_RTNL();
> 
> Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.
> 
> Fixes: 15180eca569b net: ethernet: ti: cpsw: fix vlan mcast
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Applied.