netdev - Re: [PATCH net] tipc: block BH before using dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <600a753d-6cf1-4d02-d6f4-ff8e68a42d58@i-love.sakura.ne.jp>
Date:   Sat, 23 May 2020 09:28:43 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     Eric Dumazet <edumazet@...gle.com>, Jon Maloy <jmaloy@...hat.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Xin Long <lucien.xin@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        syzbot <syzkaller@...glegroups.com>,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net] tipc: block BH before using dst_cache

On Fri, May 22, 2020 at 2:30 AM Eric Dumazet <edumazet@...gle.com> wrote:
> dst_cache_get() documents it must be used with BH disabled.

Since the report was complaining about preemption at this_cpu_ptr(), and "#syz test"
request with my preemption-disable patch no longer complained, I didn't realize that
it is documented in dst_cache.h that dst_cache_get() must be called with BH disabled.
It is bug-prone that we don't have a check for complaining that BH is not disabled.