netdev - Re: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200525160537.GD762220@lunn.ch>
Date:   Mon, 25 May 2020 18:05:37 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Andy Duan <fugang.duan@....com>
Cc:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH] stmmac: platform: add "snps,dwmac-5.10a" IP
 compatible string

On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote:
> From: Andrew Lunn <andrew@...n.ch> Sent: Monday, May 25, 2020 10:11 PM
> > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote:
> > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that can
> > > avoid to define some plat data in glue layer.
> > 
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml ?
> > 
> >       Andrew
> 
> Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a version
> since it requires platform specific code to be functional, like the we implement
> glue layer driver "dwmac-imx.c" to support 5.10a on i.MX platform.
> 
> So I think it doesn't require to add the compatible string into dwmac.yaml. 

Hi Andy

It needs to be documented somewhere. If not
Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be
in an NXP specific document.

   Andrew