netdev - Re: [PATCH v2 net-next 0/6] Raw PHY TDR data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFXsbZp4jnHHSZob4_dG2FsW5dewtMMZQKyv+xaM93gvDtVWoA@mail.gmail.com>
Date:   Mon, 25 May 2020 11:03:59 -0700
From:   Chris Healy <cphealy@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH v2 net-next 0/6] Raw PHY TDR data

With NXP i.MX51 and Marvell 88E6352 and the referenced ethtool, I
tested this functionality successfully.

Tested-by: Chris Healy <cphealy@...il.com>

On Sun, May 24, 2020 at 8:28 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> Some ethernet PHYs allow access to raw TDR data in addition to summary
> diagnostics information. Add support for retrieving this data via
> netlink ethtool. The basic structure in the core is the same as for
> normal phy diagnostics, the PHY driver simply uses different helpers
> to fill the netlink message with different data.
>
> There is a graphical tool under development, as well a ethtool(1)
> which can dump the data as text and JSON.
>
> A patched ethtool(1) can be found in
> https://github.com/lunn/ethtool.git feature/cable-test-v5
>
> Thanks for Chris Healy for lots of testing.
>
> v2:
> See the individual patches but:
>
> Pass distances in centimeters, not meters
>
> Allow the PHY to round distances to what it supports and report what
> it actually used along with the results.
>
> Make the Marvell PHY use steps a multiple of 0.805 meters, its native
> step size.
>
> Andrew Lunn (6):
>   net: ethtool: Add attributes for cable test TDR data
>   net: ethtool: Add generic parts of cable test TDR
>   net: ethtool: Add helpers for cable test TDR data
>   net: phy: marvell: Add support for amplitude graph
>   net: ethtool: Allow PHY cable test TDR data to configured
>   net : phy: marvell: Speedup TDR data retrieval by only changing page
>     once
>
>  Documentation/networking/ethtool-netlink.rst |  81 ++++++
>  drivers/net/phy/marvell.c                    | 286 ++++++++++++++++++-
>  drivers/net/phy/nxp-tja11xx.c                |   2 +-
>  drivers/net/phy/phy.c                        |  67 ++++-
>  include/linux/ethtool_netlink.h              |  25 +-
>  include/linux/phy.h                          |  17 ++
>  include/uapi/linux/ethtool_netlink.h         |  67 +++++
>  net/ethtool/cabletest.c                      | 209 +++++++++++++-
>  net/ethtool/netlink.c                        |   5 +
>  net/ethtool/netlink.h                        |   1 +
>  10 files changed, 747 insertions(+), 13 deletions(-)
>
> --
> 2.27.0.rc0
>