netdev - RE: [EXT] Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR0402MB36079E73B769948E717245BEFFB30@AM6PR0402MB3607.eurprd04.prod.outlook.com>
Date:   Mon, 25 May 2020 03:16:01 +0000
From:   Andy Duan <fugang.duan@....com>
To:     "Fuzzey, Martin" <martin.fuzzey@...wbird.group>
CC:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH net 2/4] dt-bindings: fec: update the gpr
 property

From: Fuzzey, Martin <martin.fuzzey@...wbird.group> Sent: Saturday, May 23, 2020 6:16 PM
> >  - gpr: phandle of SoC general purpose register mode. Required for
> > wake on LAN
> > -  on some SoCs
> > +  on some SoCs. Register bits of stop mode control, the format is
> > +       <&gpr req_gpr req_bit>.
> > +        gpr is the phandle to general purpose register node.
> > +        req_gpr is the gpr register offset for ENET stop request.
> > +        req_bit is the gpr bit offset for ENET stop request.
> >
> 
> More of a DT binding changes policy question, do we care about supporting
> the old no argument binding too?
> 
> I don't think it actually matters seeing as the no argument gpr node binding
> was only added recently anyway.
> But it was backported to the stable trees and Documentation/bindings/ABI.txt
> says
> 
>    "Bindings can be augmented, but the driver shouldn't break when given
>      the old binding. ie. add additional properties, but don't change the
>      meaning of an existing property. For drivers, default to the original
>      behaviour when a newly added property is missing."
> 
> Myself I think this is overkill in this case and am fine with just changing the
> binding without the driver handling the old case but that's Rob's call to make I
> think.

The patch set is to add argument binding, and driver also doesn't support wol
without argument binding.

As you know, current driver only wol feature requests the property.
I am not understand why we need to support the old without argument binding.

Welcome to your suggestion for the solution.

And 'gpr' string is not good description for stop mode, I will change it to the string:
' fsl,stop-mode'.