netdev - Re: [PATCH bpf-next] tools: bpftool: clean subcommand help messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ce6f183-eee1-d4d3-7797-89e31e78cdb5@iogearbox.net>
Date:   Tue, 26 May 2020 00:20:08 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] tools: bpftool: clean subcommand help messages

On 5/23/20 3:07 AM, Quentin Monnet wrote:
> This is a clean-up for the formatting of the do_help functions for
> bpftool's subcommands. The following fixes are included:
> 
> - Do not use argv[-2] for "iter" help message, as the help is shown by
>    default if no "iter" action is selected, resulting in messages looking
>    like "./bpftool bpftool pin...".
> 
> - Do not print unused HELP_SPEC_PROGRAM in help message for "bpftool
>    link".
> 
> - Andrii used argument indexing to avoid having multiple occurrences of
>    bin_name and argv[-2] in the fprintf() for the help message, for
>    "bpftool gen" and "bpftool link". Let's reuse this for all other help
>    functions. We can remove up to thirty arguments for the "bpftool map"
>    help message.
> 
> - Harmonise all functions, e.g. use ending quotes-comma on a separate
>    line.
> 
> Signed-off-by: Quentin Monnet <quentin@...valent.com>

Applied, thanks!